Skip to content

Conversation

@quent043
Copy link
Contributor

New PR:

Useful info

  • Trello: https://trello.com/c/Z6vN29gQ/383-graph-issue-uncompleted-service
  • Description: The current PaymentComplete event does not hold enough data to know whether a service in Finished or Uncompleted. We needed to add an event param in the PaymentCompleted event as somehow the Graph does not allow to do nested queries and we needed Transaction infos update the service status.

Auto-Review checklist

  • Check if there is no merge conflict
  • If you have new .env variable, check if you add it in the .env.example file

Typing

  • Check lint feedbacks: npm run lint
  • Check prettier format feedbacks: npm run format

Modified rates to get Uncompleted service
@quent043 quent043 added the NEED REVIEW Dev is waiting for peer review label Nov 28, 2023
@quent043 quent043 requested a review from 0xRomain November 28, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NEED REVIEW Dev is waiting for peer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants