-
-
Notifications
You must be signed in to change notification settings - Fork 568
fix: solid fields should not render every field on keystroke anymore #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com>
🦋 Changeset detectedLatest commit: 13717b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 13717b3
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
==========================================
- Coverage 90.35% 89.46% -0.90%
==========================================
Files 38 48 +10
Lines 1752 1945 +193
Branches 444 488 +44
==========================================
+ Hits 1583 1740 +157
- Misses 149 184 +35
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks to a conversation I had with @KevinVandy I noticed that our Solid adapter was causing unintentional re-renders of all
form.Fields in Soild.js only - this PR fixes that by doing more referential checking on the base store.Now things go brr.