Skip to content

Conversation

@crutchcorn
Copy link
Member

Thanks to a conversation I had with @KevinVandy I noticed that our Solid adapter was causing unintentional re-renders of all form.Fields in Soild.js only - this PR fixes that by doing more referential checking on the base store.

Now things go brr.

Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2025

🦋 Changeset detected

Latest commit: 13717b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@tanstack/solid-form Patch
@tanstack/form-core Patch
@tanstack/angular-form Patch
@tanstack/form-devtools Patch
@tanstack/lit-form Patch
@tanstack/react-form Patch
@tanstack/svelte-form Patch
@tanstack/vue-form Patch
@tanstack/react-form-devtools Patch
@tanstack/solid-form-devtools Patch
@tanstack/react-form-nextjs Patch
@tanstack/react-form-remix Patch
@tanstack/react-form-start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2025

View your CI Pipeline Execution ↗ for commit 13717b3

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 48s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-29 01:13:43 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 29, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1959

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1959

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1959

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1959

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1959

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1959

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1959

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1959

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1959

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1959

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1959

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1959

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1959

commit: 13717b3

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (6892ed0) to head (13717b3).
⚠️ Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1959      +/-   ##
==========================================
- Coverage   90.35%   89.46%   -0.90%     
==========================================
  Files          38       48      +10     
  Lines        1752     1945     +193     
  Branches      444      488      +44     
==========================================
+ Hits         1583     1740     +157     
- Misses        149      184      +35     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn crutchcorn merged commit 3519cce into main Dec 29, 2025
7 checks passed
@crutchcorn crutchcorn deleted the fix-solid-double-render branch December 29, 2025 05:01
@github-actions github-actions bot mentioned this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants