Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the BLE backends by consolidating all platform-specific logic into a single TapSDK implementation using Bleak, centralizes UUID constants, and updates packaging and CI configurations.
- Moved UUID constants from model files into
tapsdk/tap.pyand removed the oldmodels/uuids.py. - Refactored
TapClientandTapSDKto use a Bleak-based scan fallback, simplified event registration methods, and unified the POSIX implementations. - Updated
setup.py(bumped minimum Python version, addedextras_require), added a GitHub Actions CI workflow, and cleaned up examples and documentation.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tapsdk/tap.py | Consolidated UUIDs, unifies backends under Bleak, new scan fallback |
| tapsdk/parsers.py | Fixed parser functions, cleaned up docstrings |
| tapsdk/models/uuids.py | Removed legacy UUID definitions |
| tapsdk/init.py | Simplified exports to core SDK classes |
| setup.py | Bumped python_requires, added extras_require |
| .github/workflows/test.yml | Introduced CI matrix for cross‐platform testing |
| examples/basic.py | Updated example to use synchronous registration methods |
| Readme.md | Fixed typos and added testing instructions |
Comments suppressed due to low confidence (3)
tapsdk/parsers.py:2
- The
tapcode_to_fingersfunction uses the constant1instead of thetapcodeparameter. It should be'{0:05b}'.format(tapcode)[::-1]to correctly convert the input code.
return '{0:05b}'.format(1)[::-1]
tapsdk/tap.py:11
- [nitpick] The
input_type_commandimport is never used in this file; consider removing it to avoid unused dependencies.
from .inputmodes import TapInputMode, input_type_command
tapsdk/tap.py:250
- [nitpick] The new BleakScanner fallback path isn’t covered by any tests; consider adding tests for scanning and device detection logic.
async with BleakScanner(detection_callback=detection_cb) as _:
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr solves #19