Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Python’s standard logging across the Tap SDK modules and example script, replacing all print calls with appropriate logger calls and configuring the example to initialize logging.
- Added module-level
logger = logging.getLogger(__name__)in SDK files and removed directprintstatements. - Converted all print-based messaging in the example (
basic.py) to uselogger.infoand configuredlogging.basicConfig. - Removed reliance on
bleak._loggerin favor of standard logging.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tapsdk/tap.py | Imported logging, set up logger, replaced prints with logs |
| tapsdk/inputmodes.py | Added module logger, switched to logger.warning |
| examples/basic.py | Configured root logger, replaced all prints with logger.info |
Comments suppressed due to low confidence (1)
tapsdk/inputmodes.py:2
- The imported InputType is not used in this module; consider removing it to avoid an unused import.
from .enumerations import InputType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pytest -q