Fix bug 1023 #1024
Open
Fix bug 1023 #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `QCOMPARE` test is replaced by a more permissive `TWX_COMPARE_DBL`. This clever macro uses relative comparison instead of absolute comparison as usually found on the net. As side effect we get two very cool technologies for free: * testing without building everything, to gain a huge amount of time. ``` mkdir build_ui && cd. buid_ui && cmake ../src/ui && cmake --build . && ctest . ``` The same holds for `unit-tests` instead of `src/ui` except that some tests are disabled. In forthcoming commits, all the test should run separately. * The summary of the configuration can be colorized, as demonstrated by the `src/ui/CMakeList.txt`. Not essential, but very handy. * Source documentation with `doxydoc`. Once configured, run `make doxydoc` and open `<binary_dir>/doxydoc/html/index.html`: Tadaaaaam! Using `docco` is not really helpfull for day to day use and Doxygen really seems the way to go. Documenting `.cmake` files is rather tricky. Next step is the documentation of `CMakeLists.txt`.
Collaborator
Author
|
I forgot that it solves issue #1019 |
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 34.73% 34.73%
=======================================
Files 148 148
Lines 17381 17381
=======================================
Hits 6038 6038
Misses 11343 11343
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mohamadharika500-jpg
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
QCOMPAREtest is replaced by a more permissiveTWX_COMPARE_DBL. This clever macro uses relative comparison instead of absolute comparison as usually found on the net.As side effect we get two very cool technologies for free:
The same holds for
unit-testsinstead ofsrc/uiexcept that some tests are disabled. In forthcoming commits, all the test should run separately.The summary of the configuration can be colorized, as demonstrated by the
src/ui/CMakeList.txt. Not essential, but very handy.Source documentation with
doxydoc. Once configured, runmake doxydocand open<binary_dir>/doxydoc/html/index.html: Tadaaaaam!Using
doccois not really helpfull for day to day use and Doxygen really seems the way to go. Documenting.cmakefiles is rather tricky. Next step is the documentation ofCMakeLists.txt.