feat(frontend): Add persistency of Analytics view after Game End #261#267
Merged
AlexanderHeffernan merged 4 commits intomainfrom Sep 30, 2025
Merged
feat(frontend): Add persistency of Analytics view after Game End #261#267AlexanderHeffernan merged 4 commits intomainfrom
AlexanderHeffernan merged 4 commits intomainfrom
Conversation
- Updated home page images. - Adjusted backdrop blur effect in ScreenBackground component for improved aesthetics. - Enhanced reconnectSession logic in APIManager to handle offline sessions for ended games. - Improved useHostSession to restore session state more effectively based on game status. - Modified styles in HostView for better responsiveness and layout consistency.
…ssets - Updated ScreenBackground component to support new props: type, noTree, and text for improved background image handling. - Adjusted usage of ScreenBackground in HomeView, PracticeView, and QuestionView to reflect new prop functionality. - Updated home page images for better visual quality.
…ssets - Updated ScreenBackground component to support new props: type, noTree, and text for improved background image handling. - Adjusted usage of ScreenBackground in HomeView, PracticeView, and QuestionView to reflect new prop functionality. - Updated home page images for better visual quality.
…node-race into galengreen/hostview
AlexanderHeffernan
approved these changes
Sep 30, 2025
Contributor
AlexanderHeffernan
left a comment
AlexanderHeffernan
left a comment
There was a problem hiding this comment.
🛡️ Pull Guard
Status: Ready to merge
Blockers: 0
Suggestions: 3
Reviewed: November 20, 2025
Solid implementation of the offline/persistency state for post-game analytics. The logic to bypass the WebSocket connection when the game is over is a smart approach to prevent connection errors.
✅ Strengths
- Clever use of a "mock" offline session in
frontend/src/types/APIManager.tsto handle the "ended" state without refactoring the entireHostSessionclass. - Responsive design improvements in
frontend/src/views/HostView.vueimprove usability on smaller screens.
🟡 Suggestions
- [Risk of Crash] The
offlineWsmock infrontend/src/types/APIManager.ts:231casts a partial object toWebSocket. IfHostSessioncalls methods likeaddEventListenerorremoveEventListener(common in socket wrappers), this will throw a runtime error. Recommend adding these as no-op functions to the mock object to be safe. - [Refactor] There is significant logic duplication in
frontend/src/types/useHostSession.tswhen mappingplayersDatatosession.playerQuestions. The code block from lines 148-157 is identical to lines 171-180. Extract this to a helper or move it outside the conditional. - [Simplification] The prop logic in
frontend/src/components/ScreenBackground.vueis becoming complex with mutually exclusive booleans (text,noTree,blur). Consider using a singlevariantprop (e.g.,'normal' | 'no-tree' | 'blur') to make the usage more explicit and less error-prone.
🔴 Blockers
- None identified.
This review was generated by Pull Guard, an AI agent operating on the Autohive platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.