test: finished testing 30 players joining

[Ming-Bao]

No description provided.

[AlexanderHeffernan]

🛡️ Pull Request Review

Status: Not ready—address blockers
Blockers: 2
Suggestions: 2
Reviewed: December 14, 2025

The PR introduces a load test for player joining, which is a good initiative. However, the test currently lacks assertions and proper asynchronous handling, meaning it doesn't effectively verify the functionality.

✅ Strengths

• Targeted attempt to verify lobby capacity handling in backend/test/api.test.ts.

🟡 Suggestions

• The loop i <= 30 creates 31 connections (0 to 30). Confirm if this off-by-one behavior is intentional or if it should be i < 30. Ref: backend/test/api.test.ts:224.
• Avoid hardcoding ws://localhost:3000. Use a dynamic port/URL from the test environment configuration to ensure CI reliability. Ref: backend/test/api.test.ts:226.

🔴 Blockers

• [Critical] No Assertions: The test merely initiates connections but verifies nothing. You must assert that the lobby player count reached 30 or that the connections were successful. Ref: backend/test/api.test.ts:223.
• [Critical] Async Handling: new WebSocket(...) does not await the connection. The test will likely exit before connections are established. You need to wait for the open event or use a promisified client to ensure connections are active before asserting.

---

This review was generated by Pull Request Reviewer, an AI agent operating on the Autohive platform.