Open
Conversation
Collaborator
Author
|
有些東西像是maxForwardSpeed、PID的值、idealDistance要實測才知道 |
BrianHu0925
reviewed
Feb 7, 2026
BrianHu0925
reviewed
Feb 7, 2026
| } | ||
|
|
||
| lostTargetFrames = 0; | ||
| double yawOutput = yawPID.calculate(vision.getTx(), 0); |
There was a problem hiding this comment.
我在想這裡用 get3dTx 會不會比較好？可以看看 @kennhung 跟 @Hannahjjj97 怎麼想
Collaborator
Author
There was a problem hiding this comment.
好，我一開始想說用度數可能比較不會受到視角模糊影響判斷到的距離
Contributor
There was a problem hiding this comment.
還是用 3d 偵測的 rotation？因為我看變數名稱是 yawOutput，所以應該是機器人會自轉？
不過現在這個 Tx 應該也行？
是說視角模糊指的是啥
Collaborator
Author
There was a problem hiding this comment.
痾視線模糊，機器人快速移動的時候視線可能會變模糊？
Collaborator
Author
There was a problem hiding this comment.
但會不會從側邊對準的時候歪掉，就機器人是正對著Tag沒錯，但身體不一定對正Hub
Hannahjjj97
requested changes
Feb 7, 2026
Hannahjjj97
reviewed
Feb 7, 2026
| @Override | ||
| public void testExit() {} | ||
| } | ||
| } No newline at end of file |
Hannahjjj97
requested changes
Feb 8, 2026
Contributor
Hannahjjj97
left a comment
Hannahjjj97
left a comment
There was a problem hiding this comment.
變數命名有些是用 m_ 開頭，幫我改掉喔
Contributor
|
Checktyle warnings 要去看一下喔，最後 file changed 那邊可以看到 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.