Ellipticity implementation #98
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I have re-wrote elliptical treatment of gaussian beam and modified corresponding test, previous AtomECS does not implement a physical elliptical gaussian beam. The updated version will be using gaussian beam with two Rayleigh range according to two transverse direction perpendicular to beam propagation direction instead of one common Rayleigh range.
Changes:
Details:
Forked a clean version of AtomECS, type “cargo test”, already produced 3 failed tests
I modified file laser/gaussian.rs, modify all the functions inside, now gaussianbeam is created by inputting
After modification following files need to be changed to adopt the updated definition of elliptical gaussian beam and make everything consisent.
Also 7 unit tests need to be modified.
Debug and modified unit test to suit correct elliptical treatment, cargo test is smoothly working, returning no error.