Fix Source.plot_sources_on_sc for non-default sensitivity curves#122
Merged
TomWagg merged 3 commits intoTeamLEGWORK:mainfrom Jun 2, 2025
Merged
Fix Source.plot_sources_on_sc for non-default sensitivity curves#122TomWagg merged 3 commits intoTeamLEGWORK:mainfrom
Source.plot_sources_on_sc for non-default sensitivity curves#122TomWagg merged 3 commits intoTeamLEGWORK:mainfrom
Conversation
Collaborator
Author
|
(Tests actually passed, just looks like I need to fix the coverage, I'll do that separately) |
katiebreivik
approved these changes
Jun 2, 2025
Collaborator
katiebreivik
left a comment
katiebreivik
left a comment
There was a problem hiding this comment.
Looks good! and classic struggle on the codecov updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous versions used the correct sensitivity curve for plotting, however the y-values of sources were incorrectly calculated using the default sensitivity curve (as not all parameters were passed between functions). This fixes those issues.
Thanks to Kierstin Sorensen for pointing out there was an issue with this plotting!