Fix SQL capitalization and format in all the Vert.x benchmarks other than vertx-web-kotlinx
#10400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo that "world" is misspelled as "word" BTW.
Contributor
Author
|
@vietj ping |
Contributor
Author
|
|
Contributor
|
It doesn't; |
Contributor
Author
|
Sorry I misread. So it looks like the failed ones are those which were already broken before this PR. From my experience working on the |
Contributor
|
My suggestion is either to fix them or tag them as broken. Anything else would just be wasting time and resources in the continuous benchmarking environment, so don't simply leave them as they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #10399 but for all the other Vert.x benchmarks.