Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @marktnoonan, do you mind taking a look at this please? It's nothing crazy but would appreciate a second pair of eyes. |
|
@chadstewart Until this is merged into the |
| xs: "425px", | ||
| // => @media (min-width: 425px) { ... } | ||
| "2xl": "1440px", | ||
| // => @media (min-width: 1440px) { ... } | ||
| "3xl": "1920px", | ||
| // => @media (min-width: 1920px) { ... } | ||
| "pass-max-screen": "1921px" | ||
| // => @media (min-width: 1921px) { ... } |
There was a problem hiding this comment.
It seems like the screen breakpoints were overridden. I didn't see any use of xs breakpoint but there are some components that use the 2xl, 3xl and pass-max-screen breakpoints
| colors: { | ||
| primary: "#165C9C", | ||
| secondary: "#101828", | ||
| gray: "#667085", | ||
| dark: "#000000", | ||
| altDark: "#222222", | ||
| altWhite: "#F0F0F0" | ||
| } |
There was a problem hiding this comment.
Colors were also overridden and there are some elements that utilize colors for text
| fontFamily: { | ||
| inter: ["Inter", "sans-serif"] |
There was a problem hiding this comment.
Not sure if this matters but before the implementation of ShadCN UI, the text used for the website was the default font established by the browser and not the Inter font. So visually there's no change font-wise across the site, but maybe it might be good to use the Inter font with NextJS so that you can use next/font across the website: https://nextjs.org/docs/pages/api-reference/components/font
Wayne-Jones
left a comment
Wayne-Jones
left a comment
There was a problem hiding this comment.
Added some comments regarding the ShadCN UI implementation
|
@chadstewart Any idea when this PR could be implemented? |
2 participants
Description
With the migration from Chakra-UI to ShadCN-UI, it needed to be set up for the project. This PR is intended to do that.
Related Issue
Resolves:
Resolves #133
Motivation and Context
See issue #133
How Has This Been Tested?
Installed a component using the ShadCN-UI CLI and added installed component into a previously completed component.
Screenshots (if appropriate):