Skip to content

Conversation

@frontier159
Copy link
Collaborator

@frontier159 frontier159 commented Jan 31, 2025

See: README for the base contracts pulled into here.

  • Commit 1: 6f4d0a5
    • Pull out OFT constructor parameters into a struct to avoid stack-too-deep in client code
    • Update Ownable etc for OpenZeppelin v4.* -- Origami's still using it for now (on the list to update)
  • Commit 2: 03c96aa
    • Add a BYO model for Ownership of OFT and OFTAdapter contract. This allows the client code to use OpenZeppelin's Ownable, but in the Origami case it is to use OrigamiElevatedAccess
  • Commit 3: f159b1d
    • Further stack-too-deep errors come up in testing or especially forge coverage where --ir-minimum is used. Commenting out this function (which is unused in tests and our contract deployments) fixes this.
    • In an ideal world - LZ would use a struct for these arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants