Skip to content

Conversation

@marshall2112
Copy link
Collaborator

@marshall2112 marshall2112 commented Jan 13, 2026

Description

What does this PR solve?

  1. Fix spice bazaar closing price history chart y-axis
    Before:
Screenshot 2026-01-13 at 4 20 14 PM

After:

Screenshot 2026-01-13 at 4 22 07 PM

and 2) Fixed multisig signing issue

Updated to also fix:

  1. Auction ended

Before:
image

After:

new ended auction page
  1. TGLD/USDS auction chart y-axis alignment issue

Before:
tgld in circ old

After:

tgld in circ new

Summary by CodeRabbit

  • New Features

    • Bar charts: optional custom Y-axis labels and dynamic Y-axis width for clearer axis text.
    • Auction UI: state-aware countdowns and status badges (Scheduled / Live / Ended) with formatted end dates.
    • Terms acceptance: supports contract-wallet (EIP-1271) signatures and records contract-wallet status on acceptance.
  • Performance

    • Chart rendering optimized with memoization for smoother updates.

✏️ Tip: You can customize this high-level summary in your review settings.

@marshall2112 marshall2112 requested a review from a team as a code owner January 13, 2026 21:20
@github-actions github-actions bot added the dapp dapp related issues/PRs label Jan 13, 2026
@marshall2112 marshall2112 force-pushed the spice-fixes-jan-13 branch 2 times, most recently from cbd9121 to 2866be7 Compare January 14, 2026 15:08
@marshall2112 marshall2112 changed the base branch from main to stage January 14, 2026 15:49
@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

Adds async EIP-1271 contract-wallet signature verification and a new async validator that returns { isValid, isContractWallet } using an ethers provider; EOA ecrecover checks remain. SpiceBazaar TOS flow now requires a provider, stores isContractWallet in localStorage, and hooks short-circuit contract wallets to skip re-verification. Separately, two BarChart components gain memoized Y-axis formatting, dynamic Y-axis width computation, and an optional yTickFormatter prop; auction UI and countdown hooks are refactored to return and consume an AuctionState-driven result.

Sequence Diagram(s)

sequenceDiagram
  participant UI as SpiceBazaarTOS UI
  participant Hook as useTosVerification
  participant Provider as Ethereum Provider
  participant Contract as Wallet Contract
  participant Local as localStorage

  UI->>Hook: submit signature, walletAddress, timestamp, provider
  Hook->>Provider: getCode(walletAddress)
  Provider-->>Hook: code (empty or non-empty)
  alt Contract wallet (non-empty code)
    Hook->>Contract: isValidSignature(hash, signature)
    Contract-->>Hook: return magic value or not
    Hook-->>UI: { isValid, isContractWallet: true }
    UI->>Local: store { signature, timestamp, walletAddress, isContractWallet: true }
  else EOA (empty code)
    Hook->>Hook: verify with ecrecover locally
    Hook-->>UI: { isValid, isContractWallet: false }
    UI->>Local: store { signature, timestamp, walletAddress, isContractWallet: false }
  end
Loading
sequenceDiagram
  participant React as React render
  participant Formatter as useMemo/useCallback helpers
  participant Chart as CustomBarChart (recharts YAxis)

  React->>Formatter: compute yAxisNumberFormatter, getYAxisLabel, yAxisWidth
  Formatter-->>React: memoized functions & width
  React->>Chart: render YAxis with width and tick content using getYAxisLabel
  Chart-->>React: paint ticks using provided label strings
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • Spice bazaar tweaks #1224 — Overlaps changes to SpiceBazaar TOS, tos utils/hooks, BarChart formatting/props, and auction state/countdown utilities; likely directly related.
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The PR title contains a typo ('aunction' instead of 'auction') and is vague—it uses 'misc' which doesn't meaningfully convey the specific changes (y-axis rendering fixes, multisig signing fix, ended auction display, and chart alignment improvements). Correct the typo and use a more specific title such as 'Fix y-axis rendering and auction state display in Spice Bazaar' to clearly convey the primary changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed PR description provides clear context with before/after screenshots for all four issues being addressed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@marshall2112 marshall2112 changed the title Fix spice bazaar closing price history chart y-axis Fix spice bazaar closing price history chart y-axis and multisig signing issue Jan 16, 2026
@marshall2112 marshall2112 changed the title Fix spice bazaar closing price history chart y-axis and multisig signing issue Fix misc spice aunction launch issues Jan 16, 2026
@TempleDAO TempleDAO deleted a comment from marshall2112 Jan 16, 2026
@marshall2112 marshall2112 added the preview-deploy PRs tagged with this will get a preview deployment label Jan 20, 2026
@marshall2112
Copy link
Collaborator Author

Deploy preview for core ready!

✅ Preview
https://core-oh4z62fmw-templedao.vercel.app
https://pr-1246-preview.templedao.link

Built with commit 18bea95.
This pull request is being automatically deployed with vercel-action

@marshall2112 marshall2112 merged commit d9baa28 into stage Jan 21, 2026
4 checks passed
@marshall2112 marshall2112 deleted the spice-fixes-jan-13 branch January 21, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dapp dapp related issues/PRs preview-deploy PRs tagged with this will get a preview deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants