-
Notifications
You must be signed in to change notification settings - Fork 33
Fix misc spice aunction launch issues #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
apps/dapp/src/components/Pages/Core/DappPages/SpiceBazaar/Spend/Chart/BarChart.tsx
Outdated
Show resolved
Hide resolved
cbd9121 to
2866be7
Compare
2866be7 to
1ea4b67
Compare
📝 WalkthroughWalkthroughAdds async EIP-1271 contract-wallet signature verification and a new async validator that returns { isValid, isContractWallet } using an ethers provider; EOA ecrecover checks remain. SpiceBazaar TOS flow now requires a provider, stores isContractWallet in localStorage, and hooks short-circuit contract wallets to skip re-verification. Separately, two BarChart components gain memoized Y-axis formatting, dynamic Y-axis width computation, and an optional yTickFormatter prop; auction UI and countdown hooks are refactored to return and consume an AuctionState-driven result. Sequence Diagram(s)sequenceDiagram
participant UI as SpiceBazaarTOS UI
participant Hook as useTosVerification
participant Provider as Ethereum Provider
participant Contract as Wallet Contract
participant Local as localStorage
UI->>Hook: submit signature, walletAddress, timestamp, provider
Hook->>Provider: getCode(walletAddress)
Provider-->>Hook: code (empty or non-empty)
alt Contract wallet (non-empty code)
Hook->>Contract: isValidSignature(hash, signature)
Contract-->>Hook: return magic value or not
Hook-->>UI: { isValid, isContractWallet: true }
UI->>Local: store { signature, timestamp, walletAddress, isContractWallet: true }
else EOA (empty code)
Hook->>Hook: verify with ecrecover locally
Hook-->>UI: { isValid, isContractWallet: false }
UI->>Local: store { signature, timestamp, walletAddress, isContractWallet: false }
end
sequenceDiagram
participant React as React render
participant Formatter as useMemo/useCallback helpers
participant Chart as CustomBarChart (recharts YAxis)
React->>Formatter: compute yAxisNumberFormatter, getYAxisLabel, yAxisWidth
Formatter-->>React: memoized functions & width
React->>Chart: render YAxis with width and tick content using getYAxisLabel
Chart-->>React: paint ticks using provided label strings
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
|
Deploy preview for core ready! ✅ Preview Built with commit 18bea95. |
Description
What does this PR solve?
Before:
After:
and 2) Fixed multisig signing issue
Updated to also fix:
Before:

After:
Before:

After:
Summary by CodeRabbit
New Features
Performance
✏️ Tip: You can customize this high-level summary in your review settings.