Draft
Conversation
arnaudvergnet
force-pushed
the
icons-collection
branch
from
d9f008a to
4feba40
Compare
arnaudvergnet
force-pushed
the
icons-collection
branch
from
4feba40 to
ccb2b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs Terralego/TerraVisu#948
This PR also fixes an issue in the
SourceFilterFieldand improves thePatternPickerUX.New user flow for creating and viewing icons. The icons list entry is only visible to users able to edit
DataLayer:Screencast_20251008_104745.webm
Icon pickers in the layer now find icons globally. The icons tab has been removed:
Screencast_20251008_104941.webm
Some improvements to the PatternPicker:
onChangeevent when the user click onvalidate. This fixes state issues where theonChangewould fire too often and also allows the user to cancel the picker by clicking on the backdrop.Screencast_20251008_105139.webm