Skip to content

Update manufacturer back link destination #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3meeb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update manufacturer back link destination #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5dd1da
Fix manufacturer back link destination
3meeb Oct 16, 2025
bfb5712
Restore manufacturer back link label
3meeb Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/integrations/manufacturers/emporia.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sidebar_position: 3

import { BackLink } from '@components/BackLink';

<BackLink to="/integrations/manufacturers/devices-and-oems" label="Devices & OEMs" />
<BackLink to="/integrations/manufacturers/devices-and-oems" label="Back to Supported Manufacturers" />
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use a relative BackLink target

Docs guidelines require internal links to be relative. Swap the absolute /integrations/manufacturers/devices-and-oems for a relative path so navigation stays guideline-compliant.

Apply this diff:

-<BackLink to="/integrations/manufacturers/devices-and-oems" label="Back to Supported Manufacturers" />
+<BackLink to="./devices-and-oems" label="Back to Supported Manufacturers" />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<BackLink to="/integrations/manufacturers/devices-and-oems" label="Back to Supported Manufacturers" />
<BackLink to="./devices-and-oems" label="Back to Supported Manufacturers" />
🤖 Prompt for AI Agents 
In docs/integrations/manufacturers/emporia.md around line 8, the BackLink target
currently uses an absolute path (/integrations/manufacturers/devices-and-oems);
replace it with a relative path (e.g., ../devices-and-oems or
../manufacturers/devices-and-oems as appropriate for the docs structure) so the
internal link is relative and conforms to docs guidelines.


# Emporia

Expand Down
2 changes: 1 addition & 1 deletion scripts/generateManufacturerPages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ sidebar_position: 3

import { BackLink } from '@components/BackLink';

<BackLink to="/integrations/manufacturers/supported-manufacturers" label="Supported Manufacturers" />
<BackLink to="/integrations/manufacturers/devices-and-oems" label="Back to Supported Manufacturers" />

# ${manufacturer.name}

Expand Down
2 changes: 1 addition & 1 deletion src/scripts/generateManufacturerPages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ sidebar_position: 3

import { BackLink } from '@components/BackLink';

<BackLink to="/integrations/manufacturers" label="Supported Manufacturers" />
<BackLink to="/integrations/manufacturers/devices-and-oems" label="Back to Supported Manufacturers" />

# ${manufacturer.name}

Expand Down