Skip to content

Adding tests for RPC #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nuthanan06 wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Adding tests for RPC #46

nuthanan06 wants to merge 12 commits into from

Conversation

@nuthanan06
Copy link
Contributor

@nuthanan06 nuthanan06 commented Nov 28, 2025

No description provided.

@nuthanan06 nuthanan06 self-assigned this Nov 28, 2025
@nuthanan06 nuthanan06 changed the title adding rpc tests Adding tests for RPC Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.14286% with 42 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ources/SolanaWalletAdapterKit/InMemoryWallet.swift 52.11% 34 Missing ⚠️
...olanaWalletAdapterKit/Deeplink/ResponseTypes.swift 33.33% 4 Missing ⚠️
Sources/SolanaTransactions/Coding/Message.swift 57.14% 3 Missing ⚠️
...aTransactions/Coding/CryptographicIdentifier.swift 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

nuthanan06 and others added 11 commits November 28, 2025 14:23
@nuthanan06
made some minor changes
2ece2fa
@Samuel-Martineau @nuthanan06
Add InMemoryWallet (#47)
c9b113b 
* add public initializers for response types

* fix visibility of transaction message

* add a convenience function to encode/decode a standalone message

* make wallet.connect result discardable

* implement InMemoryWallet
@Samuel-Martineau @nuthanan06
fix transaction encoding to improve agreement with web3.js (#48)
2810232
@Samuel-Martineau @nuthanan06
add signature.placeholder (#49)
ea5932d
@Samuel-Martineau @nuthanan06
Improve precondition/fatalError messages (#50)
00e9467
@Samuel-Martineau @nuthanan06 @dkchiem
Add tests for transaction encoding/decoding (#15)
74717ee 
Co-authored-by: Nuthanan Tharmarajah <n2tharma@uwaterloo.ca>
Co-authored-by: Nuthanan Tharmarajah <nuthanan06@users.noreply.github.com>
Co-authored-by: Dan Chiem <dan@chiem.me>
@nuthanan06
pushed transaction and get balance
3ca416d
@dkchiem @nuthanan06
Make RPC response public (#51)
e761f47
@nuthanan06
finished sign transactions
2fc774f
@nuthanan06
fixed linitng errors
098c1c1
@nuthanan06
fixed package for testing
b2f3ce3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nuthanan06 nuthanan06

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nuthanan06 @Samuel-Martineau @dkchiem