Add ConvertTime Class with Time Conversion Functionality and Unit Tests#177
Open
arafat-web wants to merge 5 commits intoTheAlgorithms:masterfrom
Open
Add ConvertTime Class with Time Conversion Functionality and Unit Tests#177arafat-web wants to merge 5 commits intoTheAlgorithms:masterfrom
arafat-web wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
arafat-web
changed the title
darwinz
reviewed
Nov 15, 2024
Comment on lines
+85
to
+91
| // Example usage | ||
| try { | ||
| $timeResult = convertTime(120, 'minutes', 'seconds'); | ||
| echo "120 minutes = $timeResult seconds\n"; | ||
| } catch (InvalidArgumentException $e) { | ||
| echo "Error: " . $e->getMessage() . "\n"; | ||
| } |
Contributor
There was a problem hiding this comment.
Let's keep examples like this in the test code, with assertions
darwinz
reviewed
Feb 3, 2025
Comment on lines
+85
to
+91
| // Example usage | ||
| try { | ||
| $timeResult = convertTime(120, 'minutes', 'seconds'); | ||
| echo "120 minutes = $timeResult seconds\n"; | ||
| } catch (InvalidArgumentException $e) { | ||
| echo "Error: " . $e->getMessage() . "\n"; | ||
| } |
Contributor
There was a problem hiding this comment.
Please remove these 7 lines of code from ConvertTime.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces the
ConvertTimeclass, providing a robust time conversion function alongside a complete suite of unit tests to ensure accurate and reliable operation.Key Features:
convertTimeFunction: Converts a specified value between various time units (e.g., seconds, minutes, hours, days, weeks, months, and years) using predefined conversion factors.Unit Tests:
The
ConvertTimeTestclass covers the following:fromandtounits with descriptive error messages.This addition enhances functionality by enabling easy and accurate time conversions while ensuring reliability through comprehensive testing.