Skip to content

[bug] Fix panic index out of range, fixes #1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p0dalirius merged 1 commit into from
Dec 19, 2025
Merged

[bug] Fix panic index out of range, fixes #1 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions searcher/searcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,45 +31,51 @@ func SearchChunk(baseOffset int64, chunk []byte, filename string, results *resul
// Search for the next 'V' in the chunk
// We look for the product id + option + version + release + modification + feature
// For example: 5770SS1V7R5M05050 (product id: 5770, Option: SS1, Version: 7, Release: 5, Modification: 0, Feature: 5050)
nextIndex := bytes.IndexByte(chunk[currentIndex:], EBCDIC_V)
// Ensure we do not find a 'V' too close to the end to safely read VxRxMx (needs 6 bytes)
searchLimit := len(chunk) - 6
if currentIndex > searchLimit {
break
}
nextIndex := bytes.IndexByte(chunk[currentIndex:searchLimit+1], EBCDIC_V)
if nextIndex == -1 {
break
}

// Check that the release and modification are valid (VxRxMx)
if chunk[currentIndex+nextIndex] != EBCDIC_V || chunk[currentIndex+nextIndex+2] != EBCDIC_R || chunk[currentIndex+nextIndex+4] != EBCDIC_M {
idx := currentIndex + nextIndex
if chunk[idx] != EBCDIC_V || chunk[idx+2] != EBCDIC_R || chunk[idx+4] != EBCDIC_M {
currentIndex += nextIndex + 1
continue
}
// Check that the release and modification are valid (VxRxMx) with digits 0-9
if chunk[currentIndex+nextIndex+1] < EBCDIC_0 || chunk[currentIndex+nextIndex+1] > EBCDIC_9 ||
chunk[currentIndex+nextIndex+3] < EBCDIC_0 || chunk[currentIndex+nextIndex+3] > EBCDIC_9 ||
chunk[currentIndex+nextIndex+5] < EBCDIC_0 || chunk[currentIndex+nextIndex+5] > EBCDIC_9 {
if chunk[idx+1] < EBCDIC_0 || chunk[idx+1] > EBCDIC_9 ||
chunk[idx+3] < EBCDIC_0 || chunk[idx+3] > EBCDIC_9 ||
chunk[idx+5] < EBCDIC_0 || chunk[idx+5] > EBCDIC_9 {
currentIndex += nextIndex + 1
continue
}

// Try to parse as LICENCEINFO2 first (1-byte header), then fall back to LICENCEINFO1 (20-byte header)

// Candidate for LICENCEINFO2
startLic2 := currentIndex + nextIndex - 7 - 1
startLic2 := idx - 7 - 1
if startLic2 >= 0 && (startLic2+licenceinfo.LICENCEINFO2_STRUCT_SIZE) <= len(chunk) {
endLic2 := startLic2 + licenceinfo.LICENCEINFO2_STRUCT_SIZE
lic2 := licenceinfo.LICENCEINFO2{}
if _, err := lic2.Unmarshal(chunk[startLic2:endLic2]); err == nil {
results.ReportResult(baseOffset+int64(currentIndex+nextIndex), filename, &lic2)
results.ReportResult(baseOffset+int64(idx), filename, &lic2)
currentIndex += nextIndex + licenceinfo.LICENCEINFO2_STRUCT_SIZE
continue
}
}

// Candidate for LICENCEINFO1
startLic1 := currentIndex + nextIndex - 7 - 20
startLic1 := idx - 7 - 20
if startLic1 >= 0 && (startLic1+licenceinfo.LICENCEINFO1_STRUCT_SIZE) <= len(chunk) {
endLic1 := startLic1 + licenceinfo.LICENCEINFO1_STRUCT_SIZE
lic1 := licenceinfo.LICENCEINFO1{}
if _, err := lic1.Unmarshal(chunk[startLic1:endLic1]); err == nil {
results.ReportResult(baseOffset+int64(currentIndex+nextIndex), filename, &lic1)
results.ReportResult(baseOffset+int64(idx), filename, &lic1)
currentIndex += nextIndex + licenceinfo.LICENCEINFO1_STRUCT_SIZE
continue
}
Expand Down