Merged
Conversation
added 16 commits
May 3, 2025 13:01
…es and media queries
…al CSS for improved theming
…imensions to use medium spacing for consistency
…esponsiveness and consistency
…d refine layout structure in Main layout
…d maintainability
…esponsiveness Enhance Main layout: add margin-top for main section on small screens Update global styles: adjust polaroid photo size and width for improved layout on small devices
…eye icons for password visibility
…ggle icons and improve layout
…dual SVG imports for GitHub, Contact, Privacy, Search, and Password visibility icons
…lity and style adjustments
Vianpyro
added
complexity: obvious
There was a problem hiding this comment.
Pull Request Overview
This PR aims to reproduce the actual website by revising the Astro configuration.
- Added Vite SVG loader plugin to support SVG imports.
- Introduced an assetsPrefix configuration for build assets.
- Moved the static output configuration to a different position in the config.
Files not reviewed (10)
- package.json: Language not supported
- src/components/Footer.astro: Language not supported
- src/components/Header.astro: Language not supported
- src/components/Icon.astro: Language not supported
- src/components/RecipeCard.astro: Language not supported
- src/components/SearchBar.astro: Language not supported
- src/layouts/Main.astro: Language not supported
- src/pages/authentication.astro: Language not supported
- src/pages/index.astro: Language not supported
- src/styles/global.css: Language not supported
| output: 'static', | ||
| build: { | ||
| format: 'file', | ||
| assets: 'compressed', |
There was a problem hiding this comment.
[nitpick] Consider adding a comment to explain the rationale behind setting 'assetsPrefix' to './' to clarify deployment assumptions for future maintainers.
Suggested change
| assets: 'compressed', | |
| assets: 'compressed', | |
| // Setting 'assetsPrefix' to './' ensures that asset paths are relative, | |
| // which is necessary for static site deployments where assets are served | |
| // from the same directory as the HTML files. |
Comment on lines
11
to
+12
| }, | ||
| output: 'static', |
There was a problem hiding this comment.
[nitpick] The 'output: static' property was repositioned compared to its original location. Grouping related configuration options together could improve clarity and maintainability.
Suggested change
| }, | |
| output: 'static', | |
| output: 'static', | |
| }, |
Vianpyro
added
status: completed
Vianpyro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.