refactor: add explicit comparison to strcmp/stricmp results

[bobtista]

• Merge not before unify(texture): Merge W3DWater and WW3D2 texture code #1989

Ran clang-tidy (bugprone-suspicious-string-compare)

[xezon]

I am surprised that no file of tools was touched. Is this correct or did it not search in Tools?

[bobtista]

I am surprised that no file of tools was touched. Is this correct or did it not search in Tools?

This seems to be about MFC and clang-tidy not mixing well. 90+% of tools files are skipped because of this.

[Skyaero42]

These are the ones it missed

PeerThread
2593: if (strcmp(key, "username") && strcmp(key, "b_flags"))

StdLocalFileSystem
244: (strcmp(filenameStr.c_str(), ".") != 0 && strcmp(filenameStr.c_str(), ".."))) {
271: (strcmp(filenameStr.c_str(), ".") != 0 && strcmp(filenameStr.c_str(), ".."))) {

Win32LocalFileSystem
142: (strcmp(findData.cFileName, ".") != 0 && strcmp(findData.cFileName, ".."))) {
168: (strcmp(findData.cFileName, ".") != 0 && strcmp(findData.cFileName, ".."))) {

Download.cpp
50: if ((strcmp(m_Server, server) != 0) || (strcmp(m_Login, username)))

W3DView.cpp
347: !strcmp(search_ref->File, ref->File) &&

Directory.cpp
100: if ( strcmp( item.cFileName, "." ) && strcmp( item.cFileName, ".." ) )

assetmgr.cpp
1350: if (!stricmp(name, node->Data()->Name)) {

texturethumbnail.cpp
40: WWASSERT(!stricmp(&name[len-4],".tga") || !stricmp(&name[len-4],".dds"));

There are also indirect issues where the result of str(i)cmp is returned e.g. ASciistring::compare.
For example controlbar.cpp line 766 this goes wrong. But I haven't looked at all of them yet.

[bobtista]

These are the ones it missed

PeerThread
2593: if (strcmp(key, "username") && strcmp(key, "b_flags"))

StdLocalFileSystem
244: (strcmp(filenameStr.c_str(), ".") != 0 && strcmp(filenameStr.c_str(), ".."))) {
271: (strcmp(filenameStr.c_str(), ".") != 0 && strcmp(filenameStr.c_str(), ".."))) {

Win32LocalFileSystem
142: (strcmp(findData.cFileName, ".") != 0 && strcmp(findData.cFileName, ".."))) {
168: (strcmp(findData.cFileName, ".") != 0 && strcmp(findData.cFileName, ".."))) {

Download.cpp
50: if ((strcmp(m_Server, server) != 0) || (strcmp(m_Login, username)))

W3DView.cpp
347: !strcmp(search_ref->File, ref->File) &&

Directory.cpp
100: if ( strcmp( item.cFileName, "." ) && strcmp( item.cFileName, ".." ) )

assetmgr.cpp
1350: if (!stricmp(name, node->Data()->Name)) {

texturethumbnail.cpp
40: WWASSERT(!stricmp(&name[len-4],".tga") || !stricmp(&name[len-4],".dds"));

There are also indirect issues where the result of str(i)cmp is returned e.g. ASciistring::compare. For example controlbar.cpp line 766 this goes wrong. But I haven't looked at all of them yet.

the ones that are not in Tools should be fixed now

[xezon]

Is this change complete or still missing edits?

[bobtista]

Is this change complete or still missing edits?

I ran it again, should be complete

[bobtista]

I found and fixed the rest that I could find with manual search (in the tools)

[xezon]

Looks all correct to me. I did not check if this is complete.

This change must not be merged before #1989, because texturethumbnail.cpp will conflict.