refactor: Apply the readability-container-size-empty check with clang-tidy

[bobtista]

Ran clang-tidy (readability-container-size-empty))

[xezon]

Nice improvement. With std::list from STLPort this can give small performance gains too.

[xezon]

Is this change complete or is it still missing checks from files it previously failed on?

[bobtista]

Is this change complete or is it still missing checks from files it previously failed on?

I ran it again, it should have all the changes it's going to find for now.

[Caball009]

If you search in Visual Studio with regex query [>\.] *size *\( *\) *.[>=] *0, you should still find a couple, including some size() > 0 cases.

[xezon]

Maybe clang tidy is not good enough and we always need a manual pass as well.

[bobtista]

I think there are lots of files that it skips, and some files require multiple runs. It takes me 30min+ on my windows machine to run it on the repo, though I try to do things like output the files it touches for a given check and then only rerun it on those files. I think in order to be 100% done with a check yes we should check manually after running the tool. After mfc is removed it will cover more files for example

[xezon]

Ok then how about we do a clang-tidy run and then afterwards do another scripted or manual pass to fix whatever it has missed. So essentially it would be good to improve the same kind of thing across all files and not be at the mercy of clang-tidy to find it for us, but just help us kick it off.

As Caball009 has shown, we can regex search to find more occurences and then fix them.

[bobtista]

Fixed the remaining ones I could find, rebased main

[xezon]

Looks all correct. I did not look if this is complete.

[Caball009]

I see zero remaining cases for that regex query, so I presume all cases have been taken care of.