-
Notifications
You must be signed in to change notification settings - Fork 0
[MIG] calendar_shared_ics #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0
Are you sure you want to change the base?
Conversation
92f0d6b to
b44094a
Compare
| <p class="text-muted"> | ||
| If you have access to Odoo, you can open the feed record: | ||
| </p> | ||
| <a t-att-href="backend_url" class="btn btn-outline-secondary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be kinda cool to have the others as a link also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the original idea was to click on the weburl and then thunderbird would automatically init and import the calendar. Though it does not always work like that, that's why I kept it as a copyable link. I can switch around that too of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so if this is clickable, then the events that are contained in the ics are imported. No new calendar subscription is automatically created. So user should create it manually with that link
|
(@thomaspaulb note that you are checking the 14.0 version, which is basically the same as the 16.0 version with a small change in the controller. So better let's finish 16.0, and 14.0 will be auto-finished then) |
| domain.append(("partner_ids", "in", [self.partner_id.id])) | ||
| if self.domain: | ||
| extra = safe_eval(self.domain.strip(), {"uid": self.env.uid}) | ||
| domain += list(extra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we still add the "items >= now - 7 days" domain? So items in the past are excluded from sync. To up the sync speed.
|
|
||
| def _combine_ics_files(self, events, files_by_event_id): | ||
| """Combine individual VCALENDAR payloads into one VCALENDAR bytes.""" | ||
| combined = vobject.iCalendar() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to encode the name of the calendar?
Now Thunderbird defaults to the endpoint name I think, for me it's ics on:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did something about it, that did not work. Nevertheless, I do not think that we should configure this too. User can edit the name themselves
f523df4 to
1a06402
Compare
1a06402 to
19b2d04
Compare
af595c4 to
8eb8dca
Compare
8eb8dca to
57cf0b0
Compare
No description provided.