Fixed weird script tag behaviour and changed id/class highlighting #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id tags to have the same highlighting as the standard css tm-bundle, and made a few changes to the highlighting of the script tag: now the parens are highlighted as well
* Fixed issue where equals character in script tags wouldn't highlight properly * Added support for javascript highlighting following top-level if/else statements * Added support for highlighting variable references of the form =someVariable or !=someUnescapedVariable within tag parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.somethingclasses and#something-elseIDs so that it is consistent with the built-in CSS highlighting rules (classes are treated as entities and IDs are treated as variables, which isn't really very descriptive but is far more useful when trying to see what's going on at a glance)@tjholowaychuk