test #3
Open
test #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) --- updated-dependencies: - dependency-name: lodash dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add FastAPI support with an ASGI Middleware * Fix PR comments
Initial checkin of laravel-sqlcommenter (PHP). This PR contains the library code, few utilities and unit tests for utilities. In the next set of PRs, integration tests will be added.
This PR adds 1. Sample application, updates them to use sqlcommenter-php library and runs integration test on that. 2. Github workflows for unit and integration tests.
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.2) --- updated-dependencies: - dependency-name: moment dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR fixes a zero day issue where comments are added after the end of SQL statement i.e. after `;`. This will create no or wrong association of the comment wrt the SQL statement. We previously fixed it for psycopg2 only, but this CL reactors the code and fixes the issue for sqlalchemy and as a precaution was added to django also.
#126) * Adding asgiref as mandatory package while installing python sqlcommenter library * Added asgiref and fastapi depencies in python tox.ini
This PR introduces a basic CI workflow for PHP SQLCommenter. The workflow is as follows: 1. On creating a PR on PHP SQLCommenter Laravel library code, we will run integration and unit tests. 2. After a PHP SQLCommenter Laravel library code PR is merged, we push the library code into `sqlcommenter-php` repository
Updating laravel source ReadMe
As this repo's contents will be pushed to `sqlcommenter-php` repo to publish to PHP.
Add Dummy tests for all libraries except laravel-sqlcommenter. When we are adding status check to checkin code for PHP SQLCommenter, the same status check is added for all other libraries also, as this is a mono-repo. To avoid that, we are following a strategy of selective filtering instead and tests will have same name but selectively filter what to run on the basis of path.
…noring other databases (#127) Add support for multiple connection in django sqlcommenter We used the `connections` middleware instead of `connections` to support multiple databases instead of only the default database. TESTED=unittests
working sample application
added method to route in SQLCommenterMiddleware
sample application prepare-statement, go mod tidy on database/sql
updated docs
gh-pages workflow
workflow_dispatch
workflow_dispatch:
github pages workflow fix
github pages workflow fix
github pages workflow fix
* Always escape values in comments as per specification * escape
There were few libraries CI missing. So, added them.
* Fix a missing import * Update sql to use the new core * updated more libraries
* Updated database/sql to use core-0.1.2 * Fix SQLCommenter database/sql test * Ran go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.