Add ;vote slash command + restart safe interactions#672
Closed
Huntifer-RotMG wants to merge 1 commit intomasterfrom
Closed
Add ;vote slash command + restart safe interactions#672Huntifer-RotMG wants to merge 1 commit intomasterfrom
Huntifer-RotMG wants to merge 1 commit intomasterfrom
Conversation
…ommandparser upgrades; and add vote slash command
ghost
reviewed
Feb 4, 2024
ghost
suggested changes
Feb 4, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
mostly looks good to me, i would include a change to findChannel in extentions.js used on line 70 or catch this edge case in vote.js. typing the name of a channel that shares the name of a category can load the category into the configuration and therefore errors when sending the vote.
Contributor
Author
|
Closing in favor of #751 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViBot [8.11.0]
Changelog
Features
Changes
Definitely open to design feedback on this, my focus was on adding new features and less on perfecting the style/design of this function. That said, I do this this is pretty solid.