fix: resolve intermittent coverage failure in server tests #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace time.Sleep with channel-based synchronization in server shutdown tests to ensure deterministic execution: - TestServer_Shutdown_WithRunningServers: Add httpReady/httpsReady channels to wait for Serve goroutines to start before shutdown - TestServer_Shutdown_ErrorPaths: Same synchronization plus WaitGroup to ensure HTTP request goroutines complete before test ends This fixes an intermittent CI failure where line 123 of server.go (httpServer.Shutdown) was reported as uncovered due to race conditions in coverage tracking.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Docker Images BuiltImages are available for testing: # gatekeeperd
docker pull ghcr.io/tight-line/gatekeeperd:pr-13-4960335
# gatekeeper-relay
docker pull ghcr.io/tight-line/gatekeeper-relay:pr-13-4960335docker-compose.ymlGATEKEEPERD_IMAGE=ghcr.io/tight-line/gatekeeperd:pr-13-4960335 \
RELAY_IMAGE=ghcr.io/tight-line/gatekeeper-relay:pr-13-4960335 \
docker-compose --profile relay upHelm (values override)image:
repository: ghcr.io/tight-line/gatekeeperd # or gatekeeper-relay
tag: "pr-13-4960335"Images expire ~15 days after PR closes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace time.Sleep with channel-based synchronization in server shutdown tests to ensure deterministic execution:
This fixes an intermittent CI failure where line 123 of server.go (httpServer.Shutdown) was reported as uncovered due to race conditions in coverage tracking.