Filter out the log stream which have event timestamps which specify a…#1
Open
peakxu wants to merge 1 commit intoTim-B:masterfrom
Open
Filter out the log stream which have event timestamps which specify a…#1peakxu wants to merge 1 commit intoTim-B:masterfrom
peakxu wants to merge 1 commit intoTim-B:masterfrom
Conversation
… non-overlapping interval with the period of interest
Owner
|
Thanks for the pull request, that's a good point about the number of log streams. I noticed they also recently introduced the filter_log_events function which can return results across all log streams. I was thinking about using that function instead with either an empty filter pattern or with a new parameter to filter the results. Can you think of any down sides to that approach? |
Author
|
Didn't realize there was a filter_log_events function. That sounds like a great fit for this use case. Can't think of any downsides off the top of my head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… non-overlapping interval with the period of interest
@Tim-B, please review.
The metadata on the log streams can be used to filter out log streams which do not have events that overlap with the period of interest. In cases like use with Amazon Lambda, where hundreds or thousands of log streams may be generated, this can result in a significant reduction in the number of log stream calls.