Adding support for S3 function code updates. Updated mocks and README#95
Closed
toshke wants to merge 1 commit intoTim-B:masterfrom
Closed
Adding support for S3 function code updates. Updated mocks and README#95toshke wants to merge 1 commit intoTim-B:masterfrom
toshke wants to merge 1 commit intoTim-B:masterfrom
Conversation
Author
|
Will check the tests in upcoming days, and comply with coding conventions. |
Author
|
@piercus i've already opened #102, including mocks tests and code that passes linter with success. |
|
I'm not sure s3 upload should be done on grunt-aws-lambda, i'm suggesting to use On my point of view, to keep things granular, lambda_deploy should just be able to :
With this we can connect with see my example in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for uploading code via S3, rather than directly