Update pip to code at head #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry, this turned out to be a red herring. The real issue is that the version on pip (https://pypi.org/project/dotaservice/0.3.9/) doesn't have commit 733db26. Is there any way to get an updated version on pip? |
fcfort
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning the dota2 subprocess'
stdouttosubprocess.PIPEblocks all console logging. Whenstdout == subprocess.PIPE, the dota2 process will not write anything to its console logs, regardless of the value of the-consoleor-con_logfileor dota2 flags. My guess is that since nothing is consuming that pipe, the dota2 console ends up being blocked since it can't write anything to a pipe that isn't being consumed.Tested via manual editing of the source code in my local workspace to verify what was happening.