Open
Conversation
…changing it This is a follow up to commit 7a848ed so that a download doesn't affect which version is displayed as the currently live version while a non-live file is being downloaded.
normanr
force-pushed
the
main
branch
2 times, most recently
from
d39c3ef to
5f2ac84
Compare
…ing populated Dictionary only populates value creating the entry and populating the key, so concurrent access to a dictionary value could return a null value. Use a ConcurrentDictionary instead to avoid this.
…e search is correct
If two files had identical version strings then only the first would be considered for version status. This switches the lookup to be by file id so that the status is shown correctly.
The refresh is only triggered if the list is currently filtered to mods that can be updated.
…directory There's only supposed to be a manifest in the origin path, not in the version directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't the latest code (3.0.4), but it's newer than the main repo has at the moment, so probably worth pullingThis includes Tobbert's changes for Update 6 and Update 7, and my changes for Version 1.0. Please don't squash the commits (in fact just doing a fast forward would be perfectly fine with me).