Skip to content

Conversation

@liliakai
Copy link

@liliakai liliakai commented Nov 19, 2017

Add support for 🤡 🤠 🤢 🤧 and more. Because everybody wants more emoji!

Before/After
schermafbeelding 2017-11-19 om 3 03 43 pm

@rainerzufall
Copy link

@liliakai thanks so much! As a Signal (Desktop beta) user I wanted to ask for an update in your own repository, but since you are already working on updating the emojis here - i will ask here - have you by any chance missed the newest release of the iamcal/emoji-data? emoji-datasource v4.0.0 has been released only two days ago: https://github.com/iamcal/emoji-data/releases/tag/v4.0.0 & https://www.npmjs.com/package/emoji-datasource Maybe it is possible to not "only" upgrade to 3.0.0 but to directly go to 4.0.0? Thanks in any case for your work on Signal! :)

@liliakai
Copy link
Author

liliakai commented Nov 19, 2017

Thanks, @rainerzufall. Updated to emoji-datasource v4.0.0.

The emoji datasource v3.0.0 work is still available here, but the changes needed were made obsolete by v4.0.0, so I thought it would be cleaner to drop those commits entirely from this PR.

@liliakai liliakai changed the title Update to emoji-data 3.0.0 Update to emoji-data 4.0.0 Nov 19, 2017
Category names changed in emoji-data 4.0.x

diff --git a/src/map.js b/src/map.js
index c2f4dc8..45369f9 100644
--- a/src/map.js
+++ b/src/map.js
@@ -4,14 +4,14 @@ const SIZE = Constant.SIZE;
 const CATEGORY = Constant.CATEGORY;

 const categoryDataMap = {
-  Activity: CATEGORY.ACTIVITY,
-  Flags: CATEGORY.FLAGS,
-  Foods: CATEGORY.FOODS,
-  Nature: CATEGORY.NATURE,
-  Objects: CATEGORY.OBJECTS,
-  People: CATEGORY.PEOPLE,
-  Places: CATEGORY.PLACES,
-  Symbols: CATEGORY.SYMBOLS
+  "Activities": CATEGORY.ACTIVITY,
+  "Flags": CATEGORY.FLAGS,
+  "Food & Drink": CATEGORY.FOODS,
+  "Animals & Nature": CATEGORY.NATURE,
+  "Objects": CATEGORY.OBJECTS,
+  "Smileys & People": CATEGORY.PEOPLE,
+  "Travel & Places": CATEGORY.PLACES,
+  "Symbols": CATEGORY.SYMBOLS
 };

 const categoryNameMap = {
Sprite format changed slightly in emoji-datasource 4.0.x

> Added gaps between images in spritesheets to avoid bleed when displaying them
> zoomed - a 1px border around each image at all sizes

https://github.com/iamcal/emoji-data/blob/v4.0.0/CHANGES.md
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 27e0123 on liliakai:master into b5213a8 on TimeToKnow:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants