Iterable VirtualConnection process_* functions result. #256
Conversation
jstnlef
left a comment
jstnlef
left a comment
There was a problem hiding this comment.
There are a lot of stylistic changes in here which are in files not directly affected by the scope of the change. Could you just scope this down to only the changes necessary for the meat of this PR? Of course, in those blocks of code you can make the stylistic changes you want.
|
Would that help if I said that the only relevant files are 'src/net/socket.rs' and 'src/net/virtual_connection.rs' ? |
|
I would say, put up a PR for the stylistic errors. We'll merge it fast, then rebase this and I'll take a look at it later tonight. |
Co-Authored-By: Timon <timonpost@hotmail.nl>
Grammar fixes Co-Authored-By: Timon <timonpost@hotmail.nl>
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
========================================
Coverage ? 97.6%
========================================
Files ? 26
Lines ? 2796
Branches ? 0
========================================
Hits ? 2729
Misses ? 67
Partials ? 0
Continue to review full report at Codecov.
|
* Most changes are in `VirtualConnection` struct to make `process_incoming` and `process_outgoing` results make iterable. * Introduced a new `PacketInfo` type. * Bugfix covered by a test, when `last_sent`, was not set when sending `Unreliable` packets. * Removed a lot of warnings when running `cargo clippy --tests`.
* Most changes are in `VirtualConnection` struct to make `process_incoming` and `process_outgoing` results make iterable. * Introduced a new `PacketInfo` type. * Bugfix covered by a test, when `last_sent`, was not set when sending `Unreliable` packets. * Removed a lot of warnings when running `cargo clippy --tests`.
3 participants
Overall codebase improvements:
VirtualConnectionstruct to makeprocess_incomingandprocess_outgoingresults make iterable.PacketInfotype.last_sent, was not set when sendingUnreliablepackets.cargo clippy --tests.This PR will allow for much easier #246 integration.