Skip to content

Add config for interface imports #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinder-cfuller merged 1 commit into from
Mar 4, 2025
Merged

Add config for interface imports #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/NodesGenerator/Config.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public struct Config: Codable, Equatable {
public var dependencyInjectionImports: Set<String>
public var builderImports: Set<String>
public var flowImports: Set<String>
public var interfaceImports: Set<String>
public var pluginListImports: Set<String>
public var viewControllerImports: Set<String>
public var dependencies: [Variable]
Expand Down Expand Up @@ -94,6 +95,7 @@ extension Config {
dependencyInjectionImports = ["NeedleFoundation"]
builderImports = []
flowImports = []
interfaceImports = []
pluginListImports = []
viewControllerImports = []
dependencies = []
Expand Down Expand Up @@ -168,6 +170,9 @@ extension Config {
flowImports =
(try? decoder.decode(CodingKeys.flowImports))
?? defaults.flowImports
interfaceImports =
(try? decoder.decode(CodingKeys.interfaceImports))
?? defaults.interfaceImports
pluginListImports =
(try? decoder.decode(CodingKeys.pluginListImports))
?? defaults.pluginListImports
Expand Down
1 change: 1 addition & 0 deletions Sources/NodesGenerator/StencilTemplate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ public enum StencilTemplate: CustomStringConvertible, Equatable, Sendable {
case .interface:
config.baseImports
.union(["Nodes"])
.union(config.interfaceImports)
case .plugin:
config.baseImports
.union(["Nodes"])
Expand Down
3 changes: 3 additions & 0 deletions Tests/NodesGeneratorTests/ConfigTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ final class ConfigTests: XCTestCase, TestFactories {
flowImports:
- <flowImports-1>
- <flowImports-2>
interfaceImports:
- <interfaceImports-1>
- <interfaceImports-2>
pluginListImports:
- <pluginListImports-1>
- <pluginListImports-2>
Expand Down
2 changes: 2 additions & 0 deletions Tests/NodesGeneratorTests/StencilTemplateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
case .interface:
expect(imports) == [
"<baseImport>",
"<interfaceImport>",
"Nodes"
]
case .plugin:
Expand Down Expand Up @@ -466,6 +467,7 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
case .interface:
expect(imports) == [
"<baseImport>",
"<interfaceImport>",
"Nodes"
]
case .plugin:
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/Support/TestFactories.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ extension TestFactories {
config.dependencyInjectionImports = ["<dependencyInjectionImport>"]
config.builderImports = ["<builderImport>"]
config.flowImports = ["<flowImport>"]
config.interfaceImports = ["<interfaceImport>"]
config.pluginListImports = ["<pluginListImport>"]
config.viewControllerImports = ["<viewControllerImport>"]
config.dependencies = [Variable(name: "<dependencyName>", type: "<dependencyType>")]
Expand Down
3 changes: 3 additions & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testConfig.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
▿ Variable
- name: "<flowProperties-name-2>"
- type: "<flowProperties-type-2>"
▿ interfaceImports: 2 members
- "<interfaceImports-1>"
- "<interfaceImports-2>"
- isObservableStoreEnabled: false
- isPeripheryCommentEnabled: true
- isPreviewProviderEnabled: true
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testConfigWithEmptyFileContents.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- "NeedleFoundation"
- flowImports: 0 members
- flowProperties: 0 elements
- interfaceImports: 0 members
- isObservableStoreEnabled: false
- isPeripheryCommentEnabled: false
- isPreviewProviderEnabled: false
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testDecodingFromEmptyString.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- "NeedleFoundation"
- flowImports: 0 members
- flowProperties: 0 elements
- interfaceImports: 0 members
- isObservableStoreEnabled: false
- isPeripheryCommentEnabled: false
- isPreviewProviderEnabled: false
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testDecodingWithEmptyArray.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- "NeedleFoundation"
- flowImports: 0 members
- flowProperties: 0 elements
- interfaceImports: 0 members
- isObservableStoreEnabled: false
- isPeripheryCommentEnabled: false
- isPreviewProviderEnabled: false
Expand Down
3 changes: 2 additions & 1 deletion ...pshots__/XcodeTemplatePermutationTests/testNodeViewInjectedXcodeTemplatePermutation.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...PermutationTests/testNodeXcodeTemplatePermutation.AppKit-SwiftUI-CreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...shots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.AppKit-SwiftUI.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...s/__Snapshots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.AppKit.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...eTemplatePermutationTests/testNodeXcodeTemplatePermutation.AppKitCreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...s/__Snapshots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.Custom.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...eTemplatePermutationTests/testNodeXcodeTemplatePermutation.CustomCreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...ePermutationTests/testNodeXcodeTemplatePermutation.UIKit-SwiftUI-CreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...pshots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.UIKit-SwiftUI.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...ts/__Snapshots__/XcodeTemplatePermutationTests/testNodeXcodeTemplatePermutation.UIKit.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...deTemplatePermutationTests/testNodeXcodeTemplatePermutation.UIKitCreatedForPluginList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
3 changes: 2 additions & 1 deletion ...esGeneratorTests/__Snapshots__/XcodeTemplateTests/testNodeViewInjectedXcodeTemplate.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down
30 changes: 20 additions & 10 deletions Tests/NodesGeneratorTests/__Snapshots__/XcodeTemplateTests/testNodeXcodeTemplate.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -193,8 +194,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -327,8 +329,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -461,8 +464,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -595,8 +599,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -729,8 +734,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -863,8 +869,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -997,8 +1004,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -1131,8 +1139,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down Expand Up @@ -1265,8 +1274,9 @@
- value: "<flowPropertyType>"
▿ flowTestsImports: 1 element
- "<baseTestImport>"
▿ interfaceImports: 2 elements
▿ interfaceImports: 3 elements
- "<baseImport>"
- "<interfaceImport>"
- "Nodes"
- isNimbleEnabled: false
- isPeripheryCommentEnabled: true
Expand Down