Conversation
This reverts commit eb1acb4.
…filters I want to push down.
… Otherwise it doesnt work
…5 or b = 6 cannot be pushed down (yet).
Tmonster
force-pushed
the
pushdown-or-operators
branch
from
b65b62f to
856154f
Compare
…The expression executor evaluates every individual child of the conjunction on failing tuples, while the table filter applies the whole expression. This (i think) is the reason for the slow down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable OR filters to be pushed down. Currently this will only support or filters on the same column (i.e
a = 5 or a = 6). OR filters across columns are not yet supported for pushdown.Also converts
IN()filters toORfilters.Works on duckdb and parquet. Still need to test on CSV.
Works when comparing integral types, varchar, and bool.