Optimize menu #108
Merged
Optimize menu #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sizing - Add EntityRenderState caching to prevent visual reloading on menu open - Cache render states with proper scale (1.0F) to avoid double scaling - Fix slimes and magma cubes by setting size to 1 (smallest variant) - Disable AI and animations for consistent static rendering - Create fresh entities each time to avoid state corruption - Maintain caching benefits while fixing size and animation issues This eliminates the visual bug where mobs would initially load on default skeletons and gradually load correct models, taking up to 10 seconds for long lists of unlocked mobs in creative mode.
3 tasks
Contributor
|
I'm going to try to fix this later today. May just redo the whole caching system entirely because the current implementation has been nearly impossible to fix. |
Contributor
|
Okay, I've completely refactored the caching and put the code in my fork in the optimize_menu branch. Currently it's all working perfectly but it still requires the user to wait for loading the very first time the menu is opened. Before making a PR I will attempt to make this caching happen even earlier so all menu opens require 0 waiting for the user |
Contributor
|
YO! I got it all working pretty nicely now. Loading is very quick (1-2) seconds for first menu open, instant after that. #109 has the code, merging into optimize_menu branch |
Menu entity caching refactored and improved
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all menu optimizations by @FugLong. However, since there is still one error (cited below), the changes are still part of this PR. I hope to implement it as soon as possible.