-
Notifications
You must be signed in to change notification settings - Fork 0
fix: supporting the langchain output format! #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it's now string and not crewai output!
WalkthroughThe logic in Changes
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
tasks/agent.py (1)
8-8: Remove unused import.The
CrewOutputimport is no longer used after the logic change to handle string outputs directly.-from crewai.crews.crew_output import CrewOutput
🧹 Nitpick comments (1)
tasks/agent.py (1)
20-23: Update documentation to reflect the new output format.The function docstring still references "Crew.ai Flow" terminology, but the implementation now expects string outputs to support langchain format. Consider updating the documentation to reflect this change.
-""" -Activity that instantiates and runs the Crew.ai Flow (AgenticHivemindFlow). -It places the resulting answer into payload.content.response. -""" +""" +Activity that instantiates and runs the AgenticHivemindFlow. +It processes the resulting string answer and handles various response scenarios. +"""
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tasks/agent.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: ci / test / Test
- GitHub Check: ci / lint / Lint
🔇 Additional comments (1)
tasks/agent.py (1)
119-120: Confirmkickoff_async()return type & clean up unused import
- I did not find a local
async def kickoff_asyncin tasks/hivemind/agent.py (line 26) or elsewhere in the repo, so it’s likely inherited from theFlowbase class in the CrewAI SDK. Please verify that your current CrewAI version returns a Pythonstr(not aCrewOutput) fromkickoff_async().- Remove the now-unused
CrewOutputimport in tasks/agent.py (line 8).- Update any docstrings or logging around
crew_output(e.g., line 114) to reflect that it’s astrrather than aCrewOutputobject.
it's now string and not crewai output!
Summary by CodeRabbit