fix: wrong system prompt for rag tool! #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe system instruction within the retrieval-augmented generation (RAG) query method was updated. The explicit directive to "Pass the incoming queries without changing it." was removed, leaving only the general instruction, "You are a helpful assistant." No other logic or control flow was altered. Changes
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tasks/hivemind/agent.py(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: amindadgar
PR: TogetherCrew/agents-workflow#44
File: tasks/hivemind/agent.py:164-164
Timestamp: 2025-07-01T11:14:19.992Z
Learning: In RAG architectures using LangChain agents with custom RAG tools, the agent should pass queries unchanged to the RAG tool rather than processing them. The RAG tool itself (like `make_rag_tool` in tasks/hivemind/agent.py) handles all query processing, retrieval, and answer generation, while the agent serves as a simple intermediary. The system instruction "Pass the incoming queries without changing it" is appropriate for this separation of concerns.
tasks/hivemind/agent.py (1)
Learnt from: amindadgar
PR: TogetherCrew/agents-workflow#44
File: tasks/hivemind/agent.py:164-164
Timestamp: 2025-07-01T11:14:19.992Z
Learning: In RAG architectures using LangChain agents with custom RAG tools, the agent should pass queries unchanged to the RAG tool rather than processing them. The RAG tool itself (like `make_rag_tool` in tasks/hivemind/agent.py) handles all query processing, retrieval, and answer generation, while the agent serves as a simple intermediary. The system instruction "Pass the incoming queries without changing it" is appropriate for this separation of concerns.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ci / lint / Lint
- GitHub Check: ci / test / Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit