Skip to content

Comments

Add options to change galactic orbit integrator#156

Merged
TomWagg merged 6 commits intoTomWagg:mainfrom
jbirky:main
Jan 31, 2026
Merged

Add options to change galactic orbit integrator#156
TomWagg merged 6 commits intoTomWagg:mainfrom
jbirky:main

Conversation

@jbirky
Copy link
Contributor

@jbirky jbirky commented Jun 24, 2025

added options to change the integrator, with defaults:

integrator=gi.DOPRI853Integrator 
integrator_kwargs={"a_tol": 1e-10, "r_tol": 1e-10}

@TomWagg TomWagg self-assigned this Jun 24, 2025
@TomWagg TomWagg added the enhancement New feature or request label Jun 24, 2025
@TomWagg
Copy link
Owner

TomWagg commented Jun 24, 2025

Love this @jbirky! Just a couple of small things and then I'll merge this:

  • Please update cogsworth/_version.py and docs/modules/changelog.rst to reflect the changes (I think this is worth a bump to v2.1.1)
  • It would be nice to save this saved to the Population on file as well. Could you update Population.save() and cogsworth.pop.load()?
    • You can copy what sfh_params does for saving the integrator params
    • For saving the Integrator, you can save the class name as a string and then use getattr(gi, NAME) to get it back for cogsworth.pop.load()

@TomWagg TomWagg changed the title add integrator options Add options to change galactic orbit integrator Jun 24, 2025
@TomWagg
Copy link
Owner

TomWagg commented Jun 24, 2025

@jbirky actually do v2.1.2 sorry, I just merged a PR (#157) which did v2.1.1

@TomWagg
Copy link
Owner

TomWagg commented Jan 30, 2026

This is great @jbirky - sorry I only just saw your updates! 😅

I'll attempt to resolve the conflicts and merge this in now

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c18b658) to head (b184276).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2227      2238   +11     
=========================================
+ Hits          2227      2238   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg TomWagg merged commit 1700fd5 into TomWagg:main Jan 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants