Skip to content

Comments

Use gala v1.11#177

Merged
TomWagg merged 14 commits intomainfrom
new-gala
Dec 15, 2025
Merged

Use gala v1.11#177
TomWagg merged 14 commits intomainfrom
new-gala

Conversation

@TomWagg
Copy link
Owner

@TomWagg TomWagg commented Dec 15, 2025

This pull request introduces several important improvements and new features to the cogsworth package, most notably adding support for the latest version of the gala library, enhancing reproducibility by tracking software versions in saved population files, and fixing issues with column decoding during population loading. The default Milky Way potential has been updated throughout the codebase to align with the new gala API. Below are the most significant changes:

Support for Latest Gala and Updated Galactic Potential Defaults:

  • Updated the minimum required version of gala to 1.11.0 in setup.cfg, enabling support for time-evolving potentials and new MilkyWayPotential interfaces.
  • Replaced all uses of gp.MilkyWayPotential2022() with gp.MilkyWayPotential(version='v2') in both core code and tests to match the updated gala API. [1] [2] [3] [4] [5] [6]

Improved Reproducibility and Version Tracking:

  • When saving a population, the versions of cogsworth, COSMIC, and gala used are now stored as attributes in the output file. When loading, the code checks for mismatches and issues a warning if the versions differ, helping users track software provenance and avoid compatibility issues. [1] [2] [3]
  • Added a test to ensure that version mismatch warnings are triggered appropriately when loading population files.

Bug Fixes and Minor Improvements:

  • Fixed an issue where bpp_columns and bcm_columns were not properly decoded from byte strings to regular strings when loading population files, preventing downstream errors.
  • Changed the default binary fraction (binfrac) in the BSE settings from 0.5 to 1.0 in utils.py.

Documentation and Versioning:

  • Updated the changelog to document all the above changes and bumped the package version to 3.5.0. [1] [2]

Gala release notes found here: https://github.com/adrn/gala/releases/tag/v1.11.0

@TomWagg TomWagg self-assigned this Dec 15, 2025
@TomWagg TomWagg added enhancement New feature or request development tests, automation, code improvements labels Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6d0a6c9) to head (a7cb0de).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #177   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         2055      2068   +13     
=========================================
+ Hits          2055      2068   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg TomWagg merged commit a583a91 into main Dec 15, 2025
3 checks passed
@TomWagg TomWagg deleted the new-gala branch December 15, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development tests, automation, code improvements enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant