Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 2055 2068 +13
=========================================
+ Hits 2055 2068 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important improvements and new features to the
cogsworthpackage, most notably adding support for the latest version of thegalalibrary, enhancing reproducibility by tracking software versions in saved population files, and fixing issues with column decoding during population loading. The default Milky Way potential has been updated throughout the codebase to align with the newgalaAPI. Below are the most significant changes:Support for Latest Gala and Updated Galactic Potential Defaults:
galato1.11.0insetup.cfg, enabling support for time-evolving potentials and new MilkyWayPotential interfaces.gp.MilkyWayPotential2022()withgp.MilkyWayPotential(version='v2')in both core code and tests to match the updatedgalaAPI. [1] [2] [3] [4] [5] [6]Improved Reproducibility and Version Tracking:
cogsworth,COSMIC, andgalaused are now stored as attributes in the output file. When loading, the code checks for mismatches and issues a warning if the versions differ, helping users track software provenance and avoid compatibility issues. [1] [2] [3]Bug Fixes and Minor Improvements:
bpp_columnsandbcm_columnswere not properly decoded from byte strings to regular strings when loading population files, preventing downstream errors.binfrac) in the BSE settings from0.5to1.0inutils.py.Documentation and Versioning:
3.5.0. [1] [2]Gala release notes found here: https://github.com/adrn/gala/releases/tag/v1.11.0