Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 2068 2077 +9
=========================================
+ Hits 2068 2077 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the multiprocessing logic in the
Populationclass and refactors the test suite to use temporary directories for file I/O, ensuring better resource management and test isolation. Additionally, the package version is incremented to reflect these updates.Key changes:
Multiprocessing improvements in
Population(cogsworth/pop.py):_ensure_pooland_close_poolmethods, which handle pool creation and teardown based on configuration changes, reducing resource leaks and potential deadlocks._GLOBAL) and helper functions (_init_pool,_orbit_worker) to streamline passing arguments to worker processes, improving clarity and efficiency of parallel orbit integration.Populationconstructor.Test suite improvements:
tempfile.TemporaryDirectory, ensuring that test artifacts are cleaned up automatically and tests are isolated from one another. This change affects both population and SFH tests.Version update:
3.5.0to3.5.1to reflect these enhancements. ([cogsworth/_version.pyL1-R1](https://github.com/TomWagg/cogsworth/pull/180/files#diff-7683603b1d7af0f11b667ea5dc58350b01f89264fc6e92b967121be8bcf81d5eL1-R1))