Skip to content

Comments

Better handling of failed orbit integration#181

Merged
TomWagg merged 4 commits intomainfrom
bad
Jan 29, 2026
Merged

Better handling of failed orbit integration#181
TomWagg merged 4 commits intomainfrom
bad

Conversation

@TomWagg
Copy link
Owner

@TomWagg TomWagg commented Jan 29, 2026

This pull request introduces a new feature to the Population class, allowing users to specify a directory for saving error files (such as bad orbits) via a new error_file_path argument. This enhancement provides more flexibility and control over where error files are stored, and ensures that this setting is preserved when saving and loading populations. The default behavior now saves error files to the specified directory, or disables saving if set to None.

New feature: Error file path configuration

  • Added an error_file_path argument to the Population class, enabling users to specify a directory for saving error files generated during evolution. If set to None, error files are not saved. This argument is now used throughout the class, including in population copying and error handling. [1] [2] [3]

Error handling improvements

  • Updated the perform_galactic_evolution method to use the error_file_path when saving bad orbits, and improved the warning message to indicate where information was saved and what it includes. [1] [2]

Persistence and reproducibility

  • Modified the save and load methods to persist the error_file_path attribute, ensuring the setting is retained when saving or restoring a Population object. [1] [2] [3]

Documentation and versioning

  • Updated the documentation changelog to describe the new feature, and incremented the package version to 3.5.2. [1] [2]

@TomWagg TomWagg self-assigned this Jan 29, 2026
@TomWagg TomWagg added the enhancement New feature or request label Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (f9c6006) to head (613c9a1).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          16       16           
  Lines        2208     2211    +3     
=======================================
+ Hits         2206     2209    +3     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg TomWagg merged commit 924bc04 into main Jan 29, 2026
3 checks passed
@TomWagg TomWagg deleted the bad branch January 29, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant