Skip to content

Comments

Use cosmic-settings.json to load in the BSE defaults#183

Merged
TomWagg merged 5 commits intomainfrom
defaults
Jan 30, 2026
Merged

Use cosmic-settings.json to load in the BSE defaults#183
TomWagg merged 5 commits intomainfrom
defaults

Conversation

@TomWagg
Copy link
Owner

@TomWagg TomWagg commented Jan 29, 2026

@TomWagg remember to wait for COSMIC v3.6.2 before merging this, it requires it.

This pull request updates how the default BSE settings are determined in cogsworth, making them dynamically loaded from COSMIC's cosmic-settings.json file instead of being hardcoded. This ensures that the settings stay in sync with COSMIC's configuration and are easier to maintain. The version is also bumped to 3.5.3, and the changelog is updated accordingly.

Dynamic BSE Settings Loading:

  • The default_BSE_settings dictionary is removed from cogsworth/utils.py, and the get_default_BSE_settings function is updated to read defaults directly from COSMIC's cosmic-settings.json using importlib.resources. This ensures the settings are always up-to-date with COSMIC. [1] [2]
  • The list_BSE_defaults function now uses the updated get_default_BSE_settings to print the current defaults.

Versioning and Documentation:

  • The version in cogsworth/_version.py is bumped from 3.5.1 to 3.5.3.
  • The changelog in docs/modules/changelog.rst is updated to document the new method for determining default BSE settings and the version bump.

@TomWagg TomWagg self-assigned this Jan 29, 2026
@TomWagg TomWagg added the enhancement New feature or request label Jan 29, 2026
@TomWagg TomWagg merged commit 3347e55 into main Jan 30, 2026
1 check passed
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (613c9a1) to head (9cea752).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #183      +/-   ##
===========================================
+ Coverage   99.90%   100.00%   +0.09%     
===========================================
  Files          16        17       +1     
  Lines        2211      2226      +15     
===========================================
+ Hits         2209      2226      +17     
+ Misses          2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant