Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
===========================================
+ Coverage 99.90% 100.00% +0.09%
===========================================
Files 16 17 +1
Lines 2211 2226 +15
===========================================
+ Hits 2209 2226 +17
+ Misses 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomWagg remember to wait for COSMIC v3.6.2 before merging this, it requires it.
This pull request updates how the default BSE settings are determined in
cogsworth, making them dynamically loaded from COSMIC'scosmic-settings.jsonfile instead of being hardcoded. This ensures that the settings stay in sync with COSMIC's configuration and are easier to maintain. The version is also bumped to 3.5.3, and the changelog is updated accordingly.Dynamic BSE Settings Loading:
default_BSE_settingsdictionary is removed fromcogsworth/utils.py, and theget_default_BSE_settingsfunction is updated to read defaults directly from COSMIC'scosmic-settings.jsonusingimportlib.resources. This ensures the settings are always up-to-date with COSMIC. [1] [2]list_BSE_defaultsfunction now uses the updatedget_default_BSE_settingsto print the current defaults.Versioning and Documentation:
cogsworth/_version.pyis bumped from 3.5.1 to 3.5.3.docs/modules/changelog.rstis updated to document the new method for determining default BSE settings and the version bump.