Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
===========================================
- Coverage 100.00% 99.90% -0.10%
===========================================
Files 15 16 +1
Lines 2077 2208 +131
===========================================
+ Hits 2077 2206 +129
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
PS: if you wanted to spin this new code off into a new small package, I know some people who would use it!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the handling of photometric calculations in the codebase, focusing on the integration and use of MIST bolometric correction grids. The main changes include the addition of a new module for managing MIST bolometric corrections, updates to the photometry interface to support more flexible and modern filter naming, and general modernization and cleanup of dependencies and imports. These changes improve both the scientific accuracy and the usability of the code when working with stellar populations and their observable properties.
Photometry and Observables Modernization:
cogsworth/obs/mist.pyimplementing theMISTBolometricCorrectionGridclass, which handles downloading, caching, and interpolating MIST bolometric correction grids for a wide range of photometric systems and bands. This replaces the previous dependency on the externalisochronespackage for this functionality.get_photometryfunction (now incogsworth/obs/observables.py) to use the newMISTBolometricCorrectionGridclass, added parameters for specifying the main filter and silencing out-of-bounds warnings, and improved handling of filter naming and interpolation. [1] [2] [3] [4] [5]"Gaia_G_EDR3"instead of"G"), including in theplot_cmdfunction andget_gaia_observed_bin_numsmethod. [1] [2] [3]Code Organization and Import Updates:
observables.pymodule toobs/observables.pyand updated all imports to reflect this new structure, improving code organization and clarity. [1] [2]Infrastructure and Dependency Updates:
isochronespackage, reflecting the new internal handling of bolometric corrections.Versioning:
3.5.1to3.6.0to reflect these substantial changes.