Skip to content

Add final_pos/vel props for primaries and secondaries#189

Merged
TomWagg merged 5 commits intomainfrom
pos
Feb 13, 2026
Merged

Add final_pos/vel props for primaries and secondaries#189
TomWagg merged 5 commits intomainfrom
pos

Conversation

@TomWagg
Copy link
Owner

@TomWagg TomWagg commented Feb 12, 2026

This pull request introduces new convenience properties to the Population class for easier access to the final positions and velocities of primary and secondary stars, updates related documentation and tests, and bumps the package version. These changes improve usability and make analysis more straightforward.

Enhancements to the Population class:

  • Added final_primary_pos, final_secondary_pos, final_primary_vel, and final_secondary_vel properties to the Population class in cogsworth/pop.py. These properties provide direct access to the final positions and velocities of primary and secondary stars as numpy arrays, handling both regular and disrupted binaries. [1] [2]

Testing improvements:

  • Added a new test test_primary_secondary_pos_vel in cogsworth/tests/test_pop.py to verify the correctness of the new properties for both positions and velocities.

Documentation updates:

  • Documented the new properties and their purpose in the changelog (docs/modules/changelog.rst).
  • Updated installation instructions to recommend Python 3.11 instead of 3.10 in docs/pages/install.rst. [1] [2]

Version update:

  • Bumped the package version to 3.6.2 in cogsworth/_version.py.

@TomWagg TomWagg self-assigned this Feb 12, 2026
@TomWagg TomWagg added the enhancement New feature or request label Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b184276) to head (7397deb).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2238      2254   +16     
=========================================
+ Hits          2238      2254   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg TomWagg linked an issue Feb 13, 2026 that may be closed by this pull request
@TomWagg TomWagg merged commit c36b242 into main Feb 13, 2026
3 of 5 checks passed
@TomWagg TomWagg deleted the pos branch February 13, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require python 3.11+

1 participant