Skip to content

Comments

Ensure you can actually save with error_file_path=None#190

Merged
TomWagg merged 3 commits intomainfrom
none-error
Feb 19, 2026
Merged

Ensure you can actually save with error_file_path=None#190
TomWagg merged 3 commits intomainfrom
none-error

Conversation

@TomWagg
Copy link
Owner

@TomWagg TomWagg commented Feb 19, 2026

This pull request makes a small but important improvement to how the error_file_path attribute is handled during saving and loading in cogsworth/pop.py. The change ensures that a None value for error_file_path is consistently represented and interpreted, preventing potential issues with serialization and deserialization.

  • Saving and loading logic:
    • When saving, error_file_path is stored as the string "None" if its value is None. When loading, this string is converted back to None, ensuring consistent handling of the attribute. [1] [2]

@TomWagg TomWagg self-assigned this Feb 19, 2026
@TomWagg TomWagg added the bug Something isn't working label Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7397deb) to head (c4c7cd1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2254      2255    +1     
=========================================
+ Hits          2254      2255    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg TomWagg merged commit 846cb16 into main Feb 19, 2026
5 checks passed
@TomWagg TomWagg deleted the none-error branch February 19, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant