Add a block diagonal operator#2279
Open
MargaretDuff wants to merge 3 commits intoTomographicImaging:masterfrom
Open
Add a block diagonal operator#2279MargaretDuff wants to merge 3 commits intoTomographicImaging:masterfrom
MargaretDuff wants to merge 3 commits intoTomographicImaging:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The diagonal operator checks if a block data container is passed to it and then either goes to the old diagonal operator or a new one, which deals with the block operations (without ZeroOperators).
Written with the help of @bryceshirley
To do for merging into CIL
Testing you performed
Related issues/links
Reopens a very old issue #1568
Checklist
--->