Open
Conversation
paskino
reviewed
Apr 25, 2025
Comment on lines
3987
to
3995
| data = self.subtract.GetOutput() | ||
|
|
||
| # Retrieve the scalar data from the output | ||
| scalars = data.GetPointData().GetScalars() | ||
|
|
||
| # Check if scalars exist in the data | ||
|
|
||
| # Get the min and max scalar values | ||
| cmin, cmax = scalars.GetRange() |
Contributor
There was a problem hiding this comment.
I would have thought that this would be sufficient.
Suggested change
| data = self.subtract.GetOutput() | |
| # Retrieve the scalar data from the output | |
| scalars = data.GetPointData().GetScalars() | |
| # Check if scalars exist in the data | |
| # Get the min and max scalar values | |
| cmin, cmax = scalars.GetRange() | |
| v = self.vis_widget_reg.frame.viewer | |
| # make sure the stats are updated | |
| v.ia.Update() | |
| cmin = v.ia.GetMinimum() | |
| cmax = v.ia.GetMaximum() | |
I don't see you connected any observer?
Contributor
Author
|
07/07/2025 We will not have time to finalise the observers. Danica is going on leave. Ideally, we would want to add this feature in the CILViewer. We are pausing this PR for the moment. Edo is keener to have the #169 instead of simply this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.