feat: Add optional_products to link token create endpoint#94
Closed
gabe565 wants to merge 1 commit intoTomorrowIdeas:masterfrom
Closed
feat: Add optional_products to link token create endpoint#94gabe565 wants to merge 1 commit intoTomorrowIdeas:masterfrom
optional_products to link token create endpoint#94gabe565 wants to merge 1 commit intoTomorrowIdeas:masterfrom
Conversation
|
There are quite a lot more optional request fields and they'll add more in future for sure, so this approach of setting each field as separate argument of method call is wrong. There should be some ability of customization - like we can pass array of these values and then it'll be compatible with future Plaid versions too. For example, I'm interested to set `transactions: days_ |
|
This is better PR #87 |
Author
|
@DarkSide666 Thanks for the heads up. Closing this PR in favor of #87. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/link/token/createendpoint supports anoptional_productsrequest field. This PR addsoptional_productsas a named argument.