Skip to content

Set channel from cc or pitch bend events on tracks with no notes #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
docEdub wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

Set channel from cc or pitch bend events on tracks with no notes #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Track.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,14 @@ export class Track {
(event) => event.type === "noteOff"
) as (MidiNoteOffEvent & WithAbsoluteTime)[];

let channelIsSet = false;

while (noteOns.length) {
const currentNote = noteOns.shift();

// Set the channel based on the note.
this.channel = currentNote.channel;
channelIsSet = true;

// Find the corresponding note off.
const offIndex = noteOffs.findIndex(
Expand Down Expand Up @@ -119,6 +122,10 @@ export class Track {
(event) => event.type === "controller"
) as (MidiControllerEvent & WithAbsoluteTime)[];
controlChanges.forEach((event) => {
if (!channelIsSet) {
this.channel = event.channel;
channelIsSet = true;
}
this.addCC({
number: event.controllerType,
ticks: event.absoluteTime,
Expand All @@ -130,6 +137,10 @@ export class Track {
(event) => event.type === "pitchBend"
) as (MidiPitchBendEvent & WithAbsoluteTime)[];
pitchBends.forEach((event) => {
if (!channelIsSet) {
this.channel = event.channel;
channelIsSet = true;
}
this.addPitchBend({
ticks: event.absoluteTime,
// Scale the value between -2^13 to 2^13 to -2 to 2.
Expand Down